Repository navigation
ref: move to Ferrum's new JavaScript API - #350
Merged
Merged
Conversation
… on every Ferrum version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves Cuprite off the old
evaluate_on/evaluate_asynchelpers to Ferrum's new JavaScript API.node.evaluate(...)instead ofevaluate_on(node:, expression:)Page#setpasses the value as an argument tonode.evaluaterather than resolving the object id by handparentsuses a function declaration, so it returns nodes on every Ferrum versiontrigger(:click)waits for navigation with Ferrum'swait_for_navigation!drag_byscrolls with Ferrum'smouse.scroll_byBrowser#evaluate_asyncwraps the script in a promise built onevaluatewith a timeoutFix
Node#[]now uses the property only when it's a string, number, or boolean, and reads the attribute otherwise. Before, a property holding a node (for exampleinput.form) came back as a node instead of the attribute value.Tests
Node#[]returns the attribute for a property that holds a node